feat(mgmt): update metrics endpoints to serve new dashboard design #435
Conversation
jvallesm
changed the title
jvallesm
force-pushed
the
jvalles/ins-5379-credit-dashboard-endpoints
branch
from
e4e7c4a
to
d1807cf
Compare
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
triggered by commit: 7369e37
| optional google.protobuf.Timestamp stop = 6; | ||
| } | ||
| // The ID of the namespace that requested the pipeline triggers. | ||
| string namespace_id = 3 [(google.api.field_behavior) = REQUIRED]; |
There was a problem hiding this comment.
Perhaps this should be requester_id in order not to mix namespace (the owner of the pipeline triggers) with requester.
Also, is trigger the right term anymore or should we use run when documenting this fields?
There was a problem hiding this comment.
Perhaps this should be requester_id in order not to mix namespace (the owner of the pipeline triggers) with requester.
It was agreed to use requester_id for this parameter 🤝
| @@ -290,27 +290,13 @@ service MgmtPublicService { | |||
| rpc GetPipelineTriggerCount(GetPipelineTriggerCountRequest) returns (GetPipelineTriggerCountResponse) { | |||
| option (google.api.http) = {get: "/v1beta/metrics/vdp/pipeline/trigger-count"}; | |||
There was a problem hiding this comment.
According to the API discussion yesterday, this should look like
/pipeline-runs:count?requester_id=jvallesm&start=2024-10-15T00:00:00Z&stop=2024-10-16T00:00:00Z
| // NOTE: This method will soon return the trigger counts of a given requester. | ||
| // Returns a timeline of pipline trigger counts for a given requester. The | ||
| // response will contain one set of records (datapoints), representing the | ||
| // amount of triggers in a time bucket. | ||
| rpc ListPipelineTriggerChartRecords(ListPipelineTriggerChartRecordsRequest) returns (ListPipelineTriggerChartRecordsResponse) { | ||
| option (google.api.http) = {get: "/v1beta/metrics/vdp/pipeline/charts"}; |
There was a problem hiding this comment.
According to the API discussion yesterday, this should look like
/pipeline-runs:query-charts?requester_id=jvallesm&start=...
Because
This commit